Add new optional parameter SecuredVMOsDiskEncryptionSetId in Restore-AzRecoveryServicesBackupItem #28203
+4,173
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yServicesBackupItem
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new optional parameter CVMOsDiskEncryptionSetId to the Restore-AzRecoveryServicesBackupItem cmdlet for encrypting the OS disk of restored Confidential VMs (secured VMs with managed disks).
- Adds the
CVMOsDiskEncryptionSetIdparameter to support disk encryption set specification during VM restore operations - Updates help documentation and parameter descriptions for the new encryption functionality
- Includes comprehensive test coverage for the new parameter with multiple scenarios
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RestoreAzureRMRecoveryServicesBackupItem.cs | Adds the new CVMOsDiskEncryptionSetId parameter and integrates it into restore logic |
| IaasVmPsBackupProvider.cs | Implements backend logic to handle the encryption set ID in restore requests |
| ParamHelpMsgs.cs | Adds help message constant for the new parameter |
| CmdletParamEnums.cs | Adds the new parameter to the RestoreVMBackupItemParams enum |
| Restore-AzRecoveryServicesBackupItem.md | Updates cmdlet documentation with new parameter details |
| ChangeLog.md | Documents the new feature addition |
| ItemTests.ps1 | Adds comprehensive test function for the new parameter |
| ItemTests.cs | Registers the new test in the test framework |
Comments suppressed due to low confidence (3)
src/RecoveryServices/RecoveryServices/ChangeLog.md:21
- The parameter name in the changelog should match the actual parameter name. The changelog uses 'CVMOsDiskEncryptionSetId' but the PR title and description refer to 'SecuredVMOsDiskEncryptionSetId'. Based on the code changes, the correct name is 'CVMOsDiskEncryptionSetId'.
* Added new optional parameter CVMOsDiskEncryptionSetId in Restore-AzRecoveryServicesBackupItem.
src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.ps1:1360
- The parameter name used in the test is 'CVMOSDiskEncryptionSetId' but should be 'CVMOsDiskEncryptionSetId' to match the actual parameter name defined in the cmdlet.
$restoreJob = Restore-AzRecoveryServicesBackupItem -VaultId $vault.ID -VaultLocation $vault.Location `
src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.ps1:1372
- The parameter name used in the test is 'CVMOSDiskEncryptionSetId' but should be 'CVMOsDiskEncryptionSetId' to match the actual parameter name defined in the cmdlet.
$restoreJob = Restore-AzRecoveryServicesBackupItem -VaultId $vault.ID -VaultLocation $vault.Location `
...Services/RecoveryServices.Backup/Cmdlets/Restore/RestoreAzureRMRecoveryServicesBackupItem.cs
Outdated
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices/help/Restore-AzRecoveryServicesBackupItem.md
Outdated
Show resolved
Hide resolved
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I have added new optional parameter SecuredVMOsDiskEncryptionSetId in Restore-AzRecoveryServicesBackupItem. This parameter will take disk encryption set id as input and it will be used for encryption of restored secured VM OS disk.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.